<html>
<head><meta charset="utf-8"><title>Constify most non-trait `Duration` methods · t-libs · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/index.html">t-libs</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html">Constify most non-trait `Duration` methods</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204010902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204010902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204010902">(Jul 15 2020 at 20:48)</a>:</h4>
<p>Hello!<br>
I've rebased my PR for constify-ing Duration methods <a href="https://github.com/rust-lang/rust/pull/72481">https://github.com/rust-lang/rust/pull/72481</a> now that <code>const_if_match</code> is stable and I tried to request a review from <span class="user-mention" data-user-id="124288">@oli</span> but rust-highfive did not pick it up</p>



<a name="204011020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011020">(Jul 15 2020 at 20:49)</a>:</h4>
<p>isn't <span class="user-mention silent" data-user-id="124288">oli</span> already assigned to that pr?</p>



<a name="204011148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011148">(Jul 15 2020 at 20:50)</a>:</h4>
<p>Ah hu maybe? I don't know how to check that</p>



<a name="204011177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011177">(Jul 15 2020 at 20:50)</a>:</h4>
<p>But the labels should be set a <code>waiting-for-review</code> or something no?</p>



<a name="204011319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011319">(Jul 15 2020 at 20:51)</a>:</h4>
<p>it's on the right side column of the desktop view</p>



<a name="204011329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011329">(Jul 15 2020 at 20:52)</a>:</h4>
<p>oli is currently assigned</p>



<a name="204011413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011413">(Jul 15 2020 at 20:52)</a>:</h4>
<p>I don't know if the review state labels can be automatically changed if you are not a member</p>



<a name="204011428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011428">(Jul 15 2020 at 20:52)</a>:</h4>
<p>Did it manually rn</p>



<a name="204011513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011513">(Jul 15 2020 at 20:53)</a>:</h4>
<p>Ah right thanks <span class="user-mention" data-user-id="224471">@Lokathor</span> ! I thought it was some hidden bors status but its actually just a github assignee</p>



<a name="204011651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Constify%20most%20non-trait%20%60Duration%60%20methods/near/204011651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Constify.20most.20non-trait.20.60Duration.60.20methods.html#204011651">(Jul 15 2020 at 20:54)</a>:</h4>
<p>And thanks <span class="user-mention" data-user-id="216206">@lcnr</span> for fixing the labels. I really thought re-requesting a review would make bors (or rust-highfive?) to reset the labels</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>